-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type piracy of Base.schedule(t::Task) #32
Comments
I'd like to, but can't find an alternative to automatically pass Some more words on type piracy here: In |
It seems a related issue is already opened: JuliaLang/julia#35757 Especially this comment: JuliaLang/julia#35757 (comment) |
I haven't taken a deep look at the code yet but would it be possible to at least move the type piracy outside of the API module? In my project I embed Julia in a C++ app and I implement a meter provider that passes measurements to the C++ layer so in cases like this there is no need for that code to be in the API module itself. Should the override be in SDK instead? |
Thanks! That's a good suggestion. I think it is doable. I'll give it a try and do some tests. |
@lamdor brought up https://github.com/vchuravy/ScopedValues.jl (and the respective JuliaLang/julia#50958 PR). These are inherited across tasks, so they could potentially serve this purpose. |
It makes me a bit nervous, and also prevents packages depending on
OpenTelemetryAPI
to have proper precompilation, getting the following warning if I don't put `precompile(false):Is there any plan on not relying on type piracy?
The text was updated successfully, but these errors were encountered: