Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI API doesn't support tools in requests #6633

Open
1 task done
edanuff opened this issue Jan 5, 2025 · 2 comments
Open
1 task done

OpenAI API doesn't support tools in requests #6633

edanuff opened this issue Jan 5, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@edanuff
Copy link

edanuff commented Jan 5, 2025

Describe the bug

tools passed in via the OpenAI API are discarded. Cause of the bug appears to be that the ChatCompletionRequestParams class in extensions/openai/typing.py file does not define the tools array.

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

Make an API request that includes a tools array and the tools specified in the request will be discarded

Screenshot

No response

Logs

n/a

System Info

n/a
@edanuff edanuff added the bug Something isn't working label Jan 5, 2025
@ZipingL
Copy link

ZipingL commented Jan 8, 2025

In addition to response formats, it would be beneficial to consider them closely related for evaluation.

It would be ideal if these features were added as options to the /v1/chat/completions endpoint, as well as tool calling, since there are now many more models that support them.

I'm not particularly interested in using Ollama, but if necessary, I will. However, this would mean gradually moving away from text-generation-webui, which is not desirable at the moment.

@oobabooga
Copy link
Owner

Apparently this library is quite good for this: https://github.com/Dan-wanna-M/formatron

I personally don't have an use for function calling, but if you can find a simple way to add it, with minimal additions, a PR would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants