-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatability with taoensso.timbre logging? #6
Comments
Hi @bamarco. Onyx also uses Timbre. It's strange that it's not finding |
Both of these project classpaths fail in the same way.
|
This is the code where I'm running from one of the projects: (ns onyx-script.core
(:require [reagent.core :as reagent :refer [atom]]
[onyx-local-rt.api :as onyx]))
(enable-console-print!)
(defonce app-state (atom {:text "Hello Chestnut!"}))
(:require )
;; ^:export the function if using in ClojureScript.
(defn ^:export my-inc [segment]
(update-in segment [:n] inc))
(def job
{:workflow [[:in :inc] [:inc :out]]
:catalog [{:onyx/name :in
:onyx/type :input
:onyx/batch-size 20}
{:onyx/name :inc
:onyx/type :function
:onyx/fn ::my-inc
:onyx/batch-size 20}
{:onyx/name :out
:onyx/type :output
:onyx/batch-size 20}]
:lifecycles []})
(pprint
(-> (onyx/init job)
(onyx/new-segment :in {:n 41})
(onyx/new-segment :in {:n 84})
(onyx/drain)
(onyx/stop)
(onyx/env-summary)))
(defn greeting []
[:h1 (:text @app-state)])
(reagent/render [greeting] (js/document.getElementById "app")) |
With the local-rt dependency removed, are you able to bring in the function |
Okay so it works just fine in a clojure only environment. When I do a simple
and the dependencies are: [[org.clojure/clojure "1.8.0"]
[org.clojure/clojurescript "1.9.229"]
[org.onyxplatform/onyx-local-rt "0.9.15.5"]
[org.clojure/core.async "0.2.391"
:exclusions [org.clojure/tools.reader]]] I think the problem is either clojurescript version or the tools exclusion the former being more likely. |
Ah, yes. We've seen this before. This should do the trick: |
Ah okay. I think there's a way to do the same thing in |
I got it working with these changes: |
Great, thanks! I'll take a look soon. |
@bamarco Merged in the PR. We're coming closer towards moving from the 0.9.x release series to 0.10x, so we weren't planned to cut another 0.9. If you'd like, I can do it so you can point onyx-local-rt to use that version - or if you'd like to use your own version that's fine too. Let me know what I can do to help! |
Hi, new to onyx. I'm using
taoensso.timbre
for logging which overwrites a lot of the standard sl4j logging mechanisms. When I try to run the example program I get this error:I don't know enough about the internals of lifecycle-compile to know where to start debugging.
The text was updated successfully, but these errors were encountered: