-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operation to warn of dangling logical axioms or references to owl:deprecated classes #1
Comments
We may also want to warn in a class is slated for future deprecation: information-artifact-ontology/ontology-metadata#22 |
Currently warnings will be produced if reason attempted with dangling/deprecated
Should this ignore stuff like I just saw 10 InvalidReferenceViolation ERRORs that seem harmless, when rebuilding MRO. |
I want to follow up on @jamesaoverton comment, as when using ROBOT's ReasonOperation for a few ontologies I'm getting errors of the type:
What do you mean here by dangling when referring to Thanks @cmungall @jamesaoverton |
Rewrote queries and codes for optimization
Closing, as |
Robot on optimized model conversion
When imports are used it's common for the upstream to change. This may result in referenced classes being deprecated/obsoleted, or left dangling (i.e pointing to a class that has no axioms about it). Note that while classes should never disappear from the source ontology, they may potentially disappear from the import module depending on how that module was generated.
Some discussion here:
http://wiki.geneontology.org/index.php/Ontology_meeting_2015-02-05#Obsoleted.2Fmerged_terms_in_external_ontologies_we_cross-ref_to
Currently in GO we do this via SPARQL checks: geneontology/go-ontology#14605
but this is a bit awkward due to TBox axioms as triples. Also harder to check if something is dangling.
It may be better to have a utility in robot for detecting reference to dangling and/or deprecated classes. That utility could be used in various places
extract
, the it's generally not intended for one of the seed classes to be deprecated. This should produce a warning and optionally failure if the client asks for thisThe text was updated successfully, but these errors were encountered: