Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operation to warn of dangling logical axioms or references to owl:deprecated classes #1

Closed
cmungall opened this issue Feb 5, 2015 · 4 comments

Comments

@cmungall
Copy link
Contributor

cmungall commented Feb 5, 2015

When imports are used it's common for the upstream to change. This may result in referenced classes being deprecated/obsoleted, or left dangling (i.e pointing to a class that has no axioms about it). Note that while classes should never disappear from the source ontology, they may potentially disappear from the import module depending on how that module was generated.

Some discussion here:

http://wiki.geneontology.org/index.php/Ontology_meeting_2015-02-05#Obsoleted.2Fmerged_terms_in_external_ontologies_we_cross-ref_to

Currently in GO we do this via SPARQL checks: geneontology/go-ontology#14605

but this is a bit awkward due to TBox axioms as triples. Also harder to check if something is dangling.

It may be better to have a utility in robot for detecting reference to dangling and/or deprecated classes. That utility could be used in various places

  • in extract, the it's generally not intended for one of the seed classes to be deprecated. This should produce a warning and optionally failure if the client asks for this
  • optionally when operations such as reason are performed, give a warning that results may be incomplete. Optionally fail here.
@cmungall cmungall changed the title Add operation to warn of dangling logical axioms Add operation to warn of dangling logical axioms or references to owl:deprecated classes Dec 5, 2017
@cmungall
Copy link
Contributor Author

cmungall commented Dec 5, 2017

We may also want to warn in a class is slated for future deprecation: information-artifact-ontology/ontology-metadata#22

cmungall added a commit that referenced this issue Dec 5, 2017
Currently warnings will be produced if reason attempted with dangling/deprecated
@jamesaoverton
Copy link
Member

Should this ignore stuff like SubObjectPropertyOf of owl:topObjectProperty is dangling?

I just saw 10 InvalidReferenceViolation ERRORs that seem harmless, when rebuilding MRO.

@agbeltran
Copy link
Contributor

I want to follow up on @jamesaoverton comment, as when using ROBOT's ReasonOperation for a few ontologies I'm getting errors of the type:

ERROR Reference violation: InvalidReferenceViolation [axiom=SubObjectPropertyOf(<Property In Ontology> owl:topObjectProperty), referencedObject=owl:topObjectProperty, category=DANGLING]

What do you mean here by dangling when referring to owl:topObjectProperty?

Thanks @cmungall @jamesaoverton

jamesaoverton pushed a commit that referenced this issue Jun 19, 2018
Rewrote queries and codes for optimization
@beckyjackson
Copy link
Contributor

Closing, as reason fails with violations. Please re-open if this needs more discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants