-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add index to gstruct element func #419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks good to me and makes sense. Do you mind adding some documentation on the gh-pages branch to this section as a separate PR? THanks! |
@onsi Awesome, don't mind at all. |
zach-source
added a commit
to zach-source/gomega
that referenced
this pull request
Feb 25, 2021
Added documentation to support the onsi#419 PR.
#421 opened for documentation. |
lol omg - thanks for the ping @blgm !! |
This was referenced Mar 8, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature I've been missing and worked around with a custom counter struct. The use case is I have a small slice and just want to be able to reference the objects by index. I either sort the list or use matchers that don't care about order. I was able to add a way to make the index available while keeping backwards compatibility.
Changes
Add interface Identify - allow us to create interface funcs on top of existing code for backwards compatibility and flexibility.
Add new function IdentifierWithIndex. This identifier accepts an index along with element so you can use it in your string return value.
Add two new functions MatchElementsWithIndex, MatchAllElementsWithIndex. Essentially the same function as the original but swaps in the new IdenitiferWithIndex function so you can use the index.
Helper function IndexIdentify to provide an already created func for easy index use.
Final words
Happy to make any changes necessary. Just thought it would be helpful. Thanks!