-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solve the undefined: unix.Dup2 compile error on mips64le #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error in detail: go build ../internal/remote/output_interceptor_unix.go:41:2: undefined: unix.Dup2 ../internal/remote/output_interceptor_unix.go:42:2: undefined: unix.Dup2 there is Dup2 syscall on linux/amd64, linux/mips64le is Dup3 instead. Signed-off-by: Xiaodong Liu <[email protected]>
Search under ther
other OS can not support Dup3 syscall, but support Dup2 syscall on a few CPU architectures. |
@onsi PTAL, Thanks! |
tklauser
added a commit
to tklauser/ginkgo
that referenced
this pull request
Jan 12, 2021
The latest version of the golang.org/x/sys/unix package already implements func Dup2 using Dup3 on platforms which dont have the dup2 syscall. Use Dup2 and let x/sys/unix figure out the correct syscall. This effectivly reverts PR onsi#680. Verified that ginkgo still correctly builds on linux/mips64le.
tklauser
added a commit
to tklauser/ginkgo
that referenced
this pull request
Jan 13, 2021
The latest version of the golang.org/x/sys/unix package already implements func Dup2 using Dup3 on platforms which dont have the dup2 syscall. Use Dup2 and let x/sys/unix figure out the correct syscall. This effectivly reverts PR onsi#680. Verified that ginkgo still correctly builds on linux/mips64le.
onsi
pushed a commit
that referenced
this pull request
Jan 19, 2021
…#761) The latest version of the golang.org/x/sys/unix package already implements func Dup2 using Dup3 on platforms which dont have the dup2 syscall. Use Dup2 and let x/sys/unix figure out the correct syscall. This effectivly reverts PR #680. Verified that ginkgo still correctly builds on linux/mips64le.
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error in detail:
../internal/remote/output_interceptor_unix.go:41:2: undefined: unix.Dup2
../internal/remote/output_interceptor_unix.go:42:2: undefined: unix.Dup2
there is Dup2 syscall only on amd64, other arch is Dup3 instead.
Signed-off-by: Xiaodong Liu [email protected]