Discard exported method declaration when running ginkgo bootstrap #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ginkgo bootstrap -nodot will make compile error because it export function including method. Fix it by ignore FuncDecl if Recv is not nil. Fixes onsi#557
|
@wingyplus @unkiwii, sorry for the delay. This does indeed fix a bad problem, so I'll merge it right away. Would you like a new release cut? Typically I cut a release at the start of the month, but I'm happy to cut one sooner if that's helpful. |
|
I don't mind the wait. Thanks for the hard work (and the faster response) |
This was referenced Mar 8, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ginkgo bootstrap -nodot will make compile error because
it export function including method. Fix it by ignore FuncDecl if
Recv is not nil.
Fixes #557