Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed with attached debugger (Windows) #482

Merged

Conversation

pgroke
Copy link
Contributor

@pgroke pgroke commented Mar 13, 2021

Description

What: Only call OutputDebugStringA if there's actually something to print.

Why: This speeds up execution with a debugger attached dramatically.

GitHub Issues

Closes #481

Only call `OutputDebugStringA` if there's actually something to print. This speeds up execution with a debugger attached dramatically.
@onqtam
Copy link
Member

onqtam commented Mar 14, 2021

Thanks for the contribution! Don't worry about the 2 failing builds.

@onqtam onqtam merged commit ca44552 into doctest:dev Mar 14, 2021
@pgroke pgroke deleted the improve-speed-with-attached-debugger-Windows branch March 14, 2021 14:19
onqtam pushed a commit that referenced this pull request Mar 22, 2021
Only call `OutputDebugStringA` if there's actually something to print. This speeds up execution with a debugger attached dramatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants