Warnings when using something more than /W4 for Visual Studio

[Leandros]

There is a bug in the switch in getAssertString, it's not handling all cases:

c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_throws' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_throws_as' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_nothrow' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_fast' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_false' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_unary' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_eq' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_ne' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_lt' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_gt' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_ge' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'
c:\<redacted>\tests\doctest.h(3854,9): error C4062: enumerator 'doctest::detail::assertType::is_le' in switch of enum 'doctest::detail::assertType::Enum' is not handled
c:\<redacted>\tests\doctest.h(1018): note: see declaration of 'doctest::detail::assertType::Enum'

[onqtam]

Hi!

It's not a bug - see here - the first N values of the enum are used later (with bitwise OR) to define the assert types.

So OCLint is reporting this for you? You might suppress errors from the header in some way. I also use OCLing on the CI (travis) - see here - but I suppress some things (after I've reviewed each case that the static analyzer reported)

[Leandros]

MSVC is reporting this, since I'm compiling with warnings enabled & treated as error.

[onqtam]

Oh I see... that warning is a level 4 (and doctest is built with /W4 on multiple versions of VS) but is off by default... see here - I'll fix this in a few days/weeks - thanks for reporting!

[onqtam]

This should be fixed in the dev branch - will end up in master very soon!