Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to Python 3.11 #246

Closed
biblicabeebli opened this issue Mar 19, 2024 · 5 comments · Fixed by #248
Closed

Update project to Python 3.11 #246

biblicabeebli opened this issue Mar 19, 2024 · 5 comments · Fixed by #248
Assignees
Labels
technical debt Cruft and maintenance issues

Comments

@biblicabeebli
Copy link
Member

Creating this issue in reference to

Python 3.8 goes out of support in October, Beiwe Backend will be upgrading before that, but can't upgrade until Forest is known to be compatible 3.11. (and I encountered a requirements issue last week when I did some testing on a local environment)

@hackdna Could you please flesh-out this issue with tasks that should be done along with a python platform upgrade?

@hackdna
Copy link
Member

hackdna commented Mar 19, 2024

I'll be able to work on this some time in April. FWIW, Forest doesn't pin its dependencies (https://github.com/onnela-lab/forest/blob/develop/setup.py) and has a fairly extensive test suite (https://forest.beiwe.org/en/latest/development.html?highlight=pytest#quick-start), so if that passes it's highly likely that there are no major issues.

@hydawo
Copy link
Collaborator

hydawo commented Mar 19, 2024

@hackdna this sounds great, would you like the RA's to help with Forest testing?

@hackdna
Copy link
Member

hackdna commented Mar 19, 2024

Yes, and also troubleshooting any errors that may arise.

@hackdna hackdna added the technical debt Cruft and maintenance issues label Apr 25, 2024
@hackdna
Copy link
Member

hackdna commented May 28, 2024

@biblicabeebli Forest should be compatible with 3.11 now: #248
Please approve if it looks good to you and I'll merge it into the dev branch.

@biblicabeebli
Copy link
Member Author

Cool. We are going to be stuck for a little bit on 3.8, but the requirements issue I mentioned up at the top was due to a conflict in the old version of Celery, which has been upgraded.

The blocker will be any new Python 3.11 syntax, but running the backend's test suite (which should do the handful of imports that we need) under python 3.8 didn't explode anything.

No objections to merging this into your dev branch, any further complications should be my own fault (I suppose we might encounter new and exciting forest issues but we won't know until we try.)

@GeorgeEfstathiadis @hydawo I'm going to put this build up on the staging data processing server running under 3.8, let's make sure everyone who needs to know knows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Cruft and maintenance issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants