Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowserConfig Interface - Incorrect Required Property #49

Open
matdombrock opened this issue Feb 27, 2024 · 1 comment
Open

BrowserConfig Interface - Incorrect Required Property #49

matdombrock opened this issue Feb 27, 2024 · 1 comment

Comments

@matdombrock
Copy link

The BrowserConfig interface requires type but I don't think that's really meant to be required. The README says that all options are optional.

type : string

This should be changed to:

export interface BrowserConfig {
    type?        : string // now optional
    name?       : string
    protocol?   : 'tcp' | 'udp'
    subtypes?   : string[]
    txt?        : KeyValue
}

Making this change myself gives me the expected behavior, which is looking for all service types.

@matdombrock
Copy link
Author

Was this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant