subtypes are not used in find()!?

[rse]

The find() methods accepts subtypes, but it does not filter for me and a code review showed also no sign that subtypes is actually used in the browser.

[otaviojacobi]

Hey, any updates on this?
I have a avahi service defined like:

<service-group>

  <name replace-wildcards="yes">%h</name>

  <service>
    <type>_ssh._tcp</type>
    <subtype>_mytag._sub._ssh._tcp</subtype>
    <port>22222</port>
  </service>

</service-group>

However when I run a find on that interface it doesn't filter by the subtype, I find the service nevertheless, like:

{
  addresses: [ '192.168.0.71' ],
  rawTxt: [ <Buffer > ],
  txt: {},
  name: 'c99231e',
  fqdn: 'c99231e._ssh._tcp.local',
  host: 'c99231e.local',
  referer: { address: '192.168.0.71', family: 'IPv4', port: 5353, size: 106 },
  port: 22222,
  type: 'ssh',
  protocol: 'tcp',
  subtypes: []
}

I traced back to

bonjour-service/src/lib/browser.ts

Lines 208 to 213 in 67ed22f

	records.filter((rr: ServiceRecord) => {
	return (rr.type === 'PTR' && dnsEqual(rr.data, ptr.data) && rr.name.includes('._sub'))
	}).forEach((rr: ServiceRecord) => {
	const types = ServiceToType(rr.name)
	service.subtypes.push(types.subtype)
	})

these record not necessarily have the ._sub