Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using sls package leaves the symlinked folder in the directory #3

Open
JoeAlamo opened this issue Nov 5, 2019 · 1 comment
Open

Comments

@JoeAlamo
Copy link

JoeAlamo commented Nov 5, 2019

Hey there,

First of all, thanks for this plugin. Found it really useful with our setup to eliminate the use of function layers for common code - made it much easier to manage.

One thing I've found though, is that if you use sls package to create a package artifact of your microservice, the common symlink remains in your microservice folder.

I have worked around this via .gitignore, but it would be preferable if the plugin deleted the symlink itself after a successful package.

It seems a deploy --package <packagedir> afterwards cleans it up. I guess there is a post-package event this plugin could hook into to do the cleanup there?

Thanks,

@kingtut
Copy link

kingtut commented Mar 31, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants