Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension: Text Decoration API #3189

Open
bryphe opened this issue Feb 26, 2021 · 3 comments
Open

Extension: Text Decoration API #3189

bryphe opened this issue Feb 26, 2021 · 3 comments
Labels
A-extension Area: Extension/plugin integration, vscode or VimL enhancement New feature or request

Comments

@bryphe
Copy link
Member

bryphe commented Feb 26, 2021

An API that Onivim currently doesn't support is VSCode's text decoration API: https://code.visualstudio.com/api/references/vscode-api#DecorationRenderOptions

This is needed to support several extensions, including:

The work required will be:

It seems that some of the extensions require SVG rendering in the text decoration API (at least, bracket pair colorizer does - I suspect wallaby may as well) - so it may require building out the remaining primitives in Revery: https://github.com/revery-ui/revery/blob/18eb60e6d5b99adebcf5912d05c447e83a0f7e0b/src/SVG/Revery_SVG.re

@bryphe bryphe added A-extension Area: Extension/plugin integration, vscode or VimL enhancement New feature or request labels Feb 26, 2021
@yunti
Copy link

yunti commented Feb 26, 2021

I do love those coloured brackets 😀 can’t seem to live without them these days.

@jgr
Copy link

jgr commented Mar 31, 2021

Gitlens is how I get by without fugitive's :Gblame when I'm in VSCode, I'd love to see it supported.

@manaskarekar
Copy link

This would also enable one of my favorite features that most editors seem to miss, a highlight plugin that let's you highlight different words/sequences with different colors, persistently.

The best example of this was for jedit http://plugins.jedit.org/plugins/?Highlight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-extension Area: Extension/plugin integration, vscode or VimL enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants