Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't close terminal buffer when tabs are hidden #2251

Closed
yunti opened this issue Aug 6, 2020 · 3 comments
Closed

can't close terminal buffer when tabs are hidden #2251

yunti opened this issue Aug 6, 2020 · 3 comments
Labels
A-terminal Area: Integrated terminal A-workspace Area: Overall UX, editor layout, tabs/groups/splits etc. bug Something isn't working

Comments

@yunti
Copy link

yunti commented Aug 6, 2020

I'm using onivim in vim buffer mode which was added recently. However I can't seem to close the terminal, presumably because : doesn't open up the command mode popup like an editor does.
I can workaround this by making the terminal active and then clicking on a file in the file explorer and then doing :q.
Ideally it would be good to have a command to bind a key to open/close the terminal.

image

@bryphe
Copy link
Member

bryphe commented Aug 7, 2020

Control+W, Q might work for this to close the window - I don't think we have that hooked up, yet.

One alternative would be to run the exit command - that should close the terminal (but is a bit more verbose!)

@bryphe bryphe added A-terminal Area: Integrated terminal bug Something isn't working A-workspace Area: Overall UX, editor layout, tabs/groups/splits etc. labels Aug 7, 2020
@yunti
Copy link
Author

yunti commented Aug 7, 2020

Thanks, just tested Cmd +W and it does work (onMacos). Would be good to have a keybind to toggle open/close terminal like vscode, but thats probably a separate issue/feature request.. Shall I close this one out or do you want it left open to test other OS's? @bryphe

@bryphe
Copy link
Member

bryphe commented Jul 10, 2021

This should be better now with #3498

@bryphe bryphe closed this as completed Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-terminal Area: Integrated terminal A-workspace Area: Overall UX, editor layout, tabs/groups/splits etc. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants