You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
In keyboard.ts, there is a giant switch for handling various keycodes. This isn't maintainable to handle new scenarios, and there are several keys that are currently not supported.
Some keys that should be supported:
VolumeUp/VolumeDown
ScrollLock
Delete
The text was updated successfully, but these errors were encountered:
@bert88sta - sorry, this issue wasn't very clear :)
In retrospect the switch really isn't too bad... The bigger problem is that there are a bunch of hardcoded keybindings, like in index.tsx:
if (key === "<f3>") {
formatter.formatBuffer()
return
}
if (UI.isPopupMenuOpen()) {
if (key === "<esc>") {
UI.hidePopupMenu()
} else if (key === "<enter>") {
UI.selectPopupMenuItem(false)
} else if (key === "<C-v>") {
UI.selectPopupMenuItem(true)
} else if (key === "<C-n>") {
UI.nextPopupMenuItem()
} else if (key === "<C-p>") {
UI.previousPopupMenuItem()
}
return
}
So making those configurable is a more pressing issue, since I'm sure my random defaults that work for me aren't for everyone :)
There's some good discussion on this in #20 - I'm going to close this one in favor of that, since that has more details about that problem and potential solutions.
In keyboard.ts, there is a giant switch for handling various keycodes. This isn't maintainable to handle new scenarios, and there are several keys that are currently not supported.
Some keys that should be supported:
The text was updated successfully, but these errors were encountered: