-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an author / minter to the NFT MetadataViews #119
Comments
I tend to prefer semantics views myself. Could this be a "person/user" style view that you can give a role to? |
@bjartek I agree with you. There could also be multiple options here depending on how much flexibility we want. I think option c) would be easiest for immediate usage and integration whereas option a) and b) may require some more planning/guidance on what the common use cases would be and what user types would be needed. |
I don't really have much preference here. Feel free to post a proposal for what you want the view to look like and we can discuss it! |
I think we could go for a generic Users view but having a UserType enum to specify the type of a user. Currently I can think of two user types:
MINTER would be the user who minted the NFT and we could also have a A
Any suggestions / feedback would be highly appreciated. |
This is starting to get awfully close to an identity specification, which a lot of people have a lot of very strong feelings about, so it makes me a little nervous trying to include all this information about someone on-chain right now before we've done a lot of research about it. I'll try to share this around to see if some other people can give feedback |
Perhaps we could remove the PII (Personal Identifiable Information) and just include the bare minimum: |
I prefer the idea of having the PII removed as @bymi15 suggested. Would it be worth also having an optional description?
An NFT may have multiple authors. Adding a description could add some clarity on their roles. For example, our NFTs at The Fabricant would have a single minter, but an author to represent the garment designer, and another author to represent the material designer. |
@ph0ph0 That sounds like a good idea to have an optional description. |
Personally i would prefer type to be a string. Why restrict it to something that we think of now? |
@bjartek I was thinking that a |
Why does the UserType matter that much? For me this is just a description of what the user is, and me not allowing to use a description string here will just make this view loose its purpose. If i need to enter a discussion and change a cadence contract if I want a Curator type or Co-Author role or whatever kind of role that we do not think about now beforehand. |
I see your point - we can just have an optional description field as previously discussed and remove the UserType field. So that would make it a simple view:
How does this look? |
Instructions
Issue To Be Solved
Currently in the MetadataViews there isn't a clear way of representing the Author or Original Minter of the NFT. However, this is an essential attribute for all NFTs and can commonly be seen in most marketplaces.
Suggest A Solution
Discussion was raised in: https://discord.com/channels/613813861610684416/1007006779135250433/1013671709041233950 where @bjartek suggested two potential solutions:
displayType
in Traits view that could be calledUser
orAuthor
orCreator
address
field to specify the user's wallet address (and maybe some other optional fields such asname
)The text was updated successfully, but these errors were encountered: