Update to Cadence v1.2.2 #6608
Merged
Update to Cadence v1.2.2 #6608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attachments shipped in Cadence 1.0
turbolent
requested review from
janezpodhostnik and
zhangchiqing
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6608 +/- ##
==========================================
+ Coverage 41.15% 41.75% +0.60%
==========================================
Files 2052 1880 -172
Lines 182196 169174 -13022
==========================================
- Hits 74983 70641 -4342
+ Misses 100933 92604 -8329
+ Partials 6280 5929 -351
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
commented
Oct 30, 2024
| @@ -5,7 +5,7 @@ linters-settings: | |||
| goimports: | |||
| # put imports beginning with prefix after 3rd-party packages; | |||
| # it's a comma-separated list of prefixes | |||
| local-prefixes: github.com/onflow/flow-go | |||
| local-prefixes: github.com/onflow/flow-go/ | |||
There was a problem hiding this comment.
Previously this also incorrectly considered e.g. flow-go-sdk a local package.
This whole line should maybe just be removed instead?
SupunS
approved these changes
Oct 30, 2024
zhangchiqing
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically update to: