Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WalletConnect services from clientServices #1871

Closed
Tracked by #1872
jribbink opened this issue May 14, 2024 · 0 comments · Fixed by #1876
Closed
Tracked by #1872

Remove WalletConnect services from clientServices #1871

jribbink opened this issue May 14, 2024 · 0 comments · Fixed by #1876
Assignees

Comments

@jribbink
Copy link
Contributor

Issue to be solved

Currently, WalletConnect services are being generated & sent to FCL discovery through clientServices. However, these are unused, and ultimately, WalletConnect services shown in discovery are populated by discovery's services.json.

Because it should not be the clients' responsibility to populate discovery services (besides those which are injected into the client's browser), we should remove this.

Suggest A Solution

Remove walletconnect services from client services. Rely on FCL Discovery instead.

What are you currently working on that this is blocking?

No response

@jribbink jribbink self-assigned this May 14, 2024
@jribbink jribbink changed the title [FEATURE] Remove WalletConnect services from clientServices Remove WalletConnect services from clientServices May 14, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in 🌊 Flow 4D May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant