fix: on image load rate the 204 as error to display placeholder #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HenryT-CG
commented
Nov 14, 2024
HenryT-CG
commented
- usually the HTTP status code is 404 if the image does not exist - if so then on error the place holder is shown
- on optional images, the HTTP status code is 204 (no content) - also in this case the placeholder should be shown => this change do it so
SchettlerKoehler
approved these changes
Nov 14, 2024
tkit-dev
pushed a commit
that referenced
this pull request
Nov 15, 2024
## [5.26.0](v5.25.0...v5.26.0) (2024-11-15) ### Features * storybooks stories split into subfolders ([#581](#581)) ([b8e476e](b8e476e)) ### Bug Fixes * on image load rate the 204 as error to display placeholder ([#606](#606)) ([3129dd5](3129dd5)) * onecx versions in libs peerDependencies are now updated correctly ([#607](#607)) ([b7f2066](b7f2066)) ### Chores * **deps:** bump the angular group with 16 updates ([#608](#608)) ([4ef13b3](4ef13b3)) * **deps:** bump the angular group with 20 updates ([#601](#601)) ([fb3c747](fb3c747))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.