feat: implement ocx-content + ocx-content-container and re-enable Storybook #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 13, 2023 19:24
|
@SchettlerKoehler I can't assign you as a reviewer for some reason but I guess it makes sense if you take this one. |
SchettlerKoehler
requested changes
Dec 25, 2023
...ngular/src/lib/core/components/ocx-content-container/ocx-content-container.component.spec.ts
Show resolved
Hide resolved
...portal-integration-angular/src/lib/core/components/ocx-content/ocx-content.component.spec.ts
Show resolved
Hide resolved
libs/portal-integration-angular/src/lib/core/directives/ocx-content-container.directive.ts
Outdated
Show resolved
Hide resolved
libs/portal-integration-angular/src/lib/core/directives/ocx-content-container.directive.ts
Outdated
Show resolved
Hide resolved
added 5 commits
January 8, 2024 11:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this MR I created the components ocx-content and ocx-content-container which internally use the also newly created directives ocxContent and ocxContentContainer. Additionally, I updated all package.json files to reflect the new lib version and re-enabled Storybook to simplify component development in the future.