Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ocx-content-container spacing #279

Merged

Conversation

bastianjakobi
Copy link
Contributor

No description provided.

@bastianjakobi
Copy link
Contributor Author

This PR fixes a layout/spacing issue that @HenryT-CG detected in tenant-ui. I replaced the currently specified vertical padding with a top margin matching the margin used on other OneCX screens. This will work fine in our specific use cases. However, it will of course also add the top margin if we decide to use the content-container in other places and use cases in the future, which could create layout issues and force us to overwrite the top margin using CSS classes. From my understanding, content-container was supposed to be a general purpose component, so I'm not sure if this is what we want. What do you guys think @HenryT-CG @SchettlerKoehler ?

@bastianjakobi
Copy link
Contributor Author

Implemented new spacing concept and moved margin into page header. Should be ready to be merged now @SchettlerKoehler @HenryT-CG

@bastianjakobi bastianjakobi merged commit 409bc5d into onecx:main Jun 27, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 27, 2024
## [4.35.0](v4.34.0...v4.35.0) (2024-06-27)

### Features

* fix styling issues for page header detail values + add ability to specify icon styles ([#294](#294)) ([08d79c3](08d79c3))

### Bug Fixes

* fix csv exports by escaping delimiters ([#287](#287)) ([76eb1dc](76eb1dc))
* fix ocx-content-container spacing ([#279](#279)) ([409bc5d](409bc5d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants