From 6ab58f03bbe98fd55cb211816550a9be134f31c1 Mon Sep 17 00:00:00 2001 From: Jannik Steenken Date: Tue, 30 Jul 2024 09:18:33 +0200 Subject: [PATCH 1/6] fix: adjust accessability --- .../announcement-detail.component.html | 11 ++++++++--- .../announcement-search.component.html | 18 ++++++++++++------ src/assets/i18n/de.json | 1 + src/assets/i18n/en.json | 1 + 4 files changed, 22 insertions(+), 9 deletions(-) diff --git a/src/app/announcement/announcement-detail/announcement-detail.component.html b/src/app/announcement/announcement-detail/announcement-detail.component.html index 2f4138d..e24725f 100644 --- a/src/app/announcement/announcement-detail/announcement-detail.component.html +++ b/src/app/announcement/announcement-detail/announcement-detail.component.html @@ -63,12 +63,14 @@ - @@ -150,7 +153,9 @@ tooltipPosition="top" tooltipEvent="hover" > - + @@ -177,7 +182,7 @@ formGroup.controls['endDate'].errors?.hasOwnProperty('invalidDateRange') " class="col-12 py-0 ml-1 sm:pl-3 control-error" - for="announcement_detail_form_start_date" + for="announcement_detail_form_startDate" > {{ 'VALIDATION.ERRORS.INVALID_DATE_RANGE' | translate }} diff --git a/src/app/announcement/announcement-search/announcement-search.component.html b/src/app/announcement/announcement-search/announcement-search.component.html index 479681e..517b1ae 100644 --- a/src/app/announcement/announcement-search/announcement-search.component.html +++ b/src/app/announcement/announcement-search/announcement-search.component.html @@ -77,11 +77,12 @@ class="mr-1 my-0 p-1 p-button-rounded font-medium p-button-text p-button p-component p-button-icon-only" [id]="'ahm_announcement_search_table_row_' + row + '_view_action'" (click)="onDetail($event, rowData, 'VIEW')" + aria-label="'GENERAL.VIEW' | translate" [pTooltip]="'GENERAL.VIEW' | translate" tooltipPosition="top" tooltipEvent="hover" > - + @@ -174,6 +178,7 @@
diff --git a/src/assets/i18n/de.json b/src/assets/i18n/de.json index 9e8a3ca..a4f8410 100644 --- a/src/assets/i18n/de.json +++ b/src/assets/i18n/de.json @@ -33,6 +33,7 @@ } }, "EDIT": { + "LABEL": "Neuigkeit bearbeiten", "ANNOUNCEMENT": "Neuigkeit bearbeiten", "ANNOUNCEMENT.TOOLTIP": "Die Neuigkeit bearbeiten", "MESSAGE": { diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json index 298f139..5a05362 100644 --- a/src/assets/i18n/en.json +++ b/src/assets/i18n/en.json @@ -33,6 +33,7 @@ } }, "EDIT": { + "LABEL": "Edit Announcement", "ANNOUNCEMENT": "Edit Announcement", "ANNOUNCEMENT.TOOLTIP": "Edit the Announcement properties", "MESSAGE": { From f1674c11ab2d824e390c5d87aa708873f107fa23 Mon Sep 17 00:00:00 2001 From: Jannik Steenken Date: Tue, 30 Jul 2024 10:39:39 +0200 Subject: [PATCH 2/6] fix: primeng accessability --- .../announcement-detail/announcement-detail.component.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/app/announcement/announcement-detail/announcement-detail.component.html b/src/app/announcement/announcement-detail/announcement-detail.component.html index e24725f..afb2d74 100644 --- a/src/app/announcement/announcement-detail/announcement-detail.component.html +++ b/src/app/announcement/announcement-detail/announcement-detail.component.html @@ -1,5 +1,6 @@ Date: Tue, 30 Jul 2024 15:45:03 +0200 Subject: [PATCH 3/6] fix: id and label fixes --- .../announcement-detail.component.html | 27 +++++++++---------- .../announcement-search.component.html | 2 +- src/assets/i18n/de.json | 2 +- src/assets/i18n/en.json | 2 +- 4 files changed, 16 insertions(+), 17 deletions(-) diff --git a/src/app/announcement/announcement-detail/announcement-detail.component.html b/src/app/announcement/announcement-detail/announcement-detail.component.html index afb2d74..f464f4d 100644 --- a/src/app/announcement/announcement-detail/announcement-detail.component.html +++ b/src/app/announcement/announcement-detail/announcement-detail.component.html @@ -64,14 +64,13 @@ - @@ -135,7 +137,7 @@
- +
@@ -164,7 +163,7 @@
{{ 'VALIDATION.ERRORS.INVALID_DATE_RANGE' | translate }} diff --git a/src/app/announcement/announcement-search/announcement-search.component.html b/src/app/announcement/announcement-search/announcement-search.component.html index 517b1ae..c0752af 100644 --- a/src/app/announcement/announcement-search/announcement-search.component.html +++ b/src/app/announcement/announcement-search/announcement-search.component.html @@ -178,12 +178,12 @@