Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux executable #9

Closed
HadrienG opened this issue Dec 15, 2017 · 1 comment
Closed

Linux executable #9

HadrienG opened this issue Dec 15, 2017 · 1 comment

Comments

@HadrienG
Copy link

Hi!

I'm reviewing your Joss submission and I was having troubles with the linux executable. It appears that the .gz file available to download is actually a tar archive.

Instinctively I did

wget https://github.com/onecodex/finch-rs/releases/download/v0.1.4/finch-linux64-v0.1.4.gz
gzip -d finch-linux64-v0.1.4.gz
chmod +x finch-linux64-v0.1.4 
./finch-linux64-v0.1.4 
# -bash: ./finch-linux64-v0.1.4: cannot execute binary file

And indeed

file finch-linux64-v0.1.4
# finch-linux64-v0.1.4: POSIX tar archive (GNU)

I think it'd be less confusing for users to name the file finch-linux64-v0.1.4.tar.gz

Otherwise the software executes fine after unpacking! I may come back to you with others issues or suggestions later during the day 😃

Best,
Hadrien

@boydgreenfield
Copy link
Contributor

@HadrienG Thanks for catching that sloppy packaging! Just updated the binary to have the right extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants