Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is is intended behavior to have min max defined? #832

Closed
shangjiaxuan opened this issue May 19, 2022 · 5 comments · Fixed by #1291
Closed

Is is intended behavior to have min max defined? #832

shangjiaxuan opened this issue May 19, 2022 · 5 comments · Fixed by #1291

Comments

@shangjiaxuan
Copy link

Including tbb.h and global_control.h will pull in min max preprocessors from windows headers. This will occlude std::min and std::max usage in later code, and needs #undef. Is the preprocessors intended behavior? (Some downstream libraries breaks compilation on windows because of this.)
@shangjiaxuan
Copy link
Author

shangjiaxuan commented May 19, 2022 •
edited
Loading

Related: jrmadsen/PTL#32
Related: #603

@shangjiaxuan
Copy link
Author

Although not in included directly, enumerable_thread_specific.h seems to contain a #include <windows.h> not guarded by NOMINMAX, locations of the winapi header that contributed to this issue is unknown.

@phprus
Copy link
Contributor

phprus commented May 19, 2022

See previous issue and PR:
#573
#576

@Alexandr-Konovalov
Copy link
Contributor

Fixed in Add NOMINMAX before windows.h in enumerable_thread_specific.h

@dnmokhov dnmokhov linked a pull request Feb 13, 2024 that will close this issue
Add NOMINMAX before windows.h in enumerable_thread_specific.h #1291
Merged
14 tasks
@Alexandr-Konovalov
Copy link
Contributor

So, closed. Please reopen if the issue remains.

@ZhongRuoyu ZhongRuoyu mentioned this issue Apr 12, 2024
Merged
@Altina-oz Altina-oz mentioned this issue May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NOMINMAX before windows.h in enumerable_thread_specific.h Alexandr-Konovalov/oneTBB
3 participants
@phprus @shangjiaxuan @Alexandr-Konovalov