Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality improvements - address findings from www.codefactor.io #1912

Open
napetrov opened this issue Oct 1, 2021 · 3 comments
Open

Comments

@napetrov
Copy link
Contributor

napetrov commented Oct 1, 2021

Please create PRs for addressing code quality issues reported by codefactor scans

https://www.codefactor.io/repository/github/oneapi-src/onedal

Some problems are simple fixes and i would expect that they can be fixed across entire repo and not one by one
Other might be super complex and i don't think can be fixed without serious refactoring - code complexity

@shekhar-chauhan
Copy link

@napetrov feel free to assign any of the refactoring issues to me and @saiteja13427, would be happy to contribute.

@Amruta789
Copy link

Amruta789 commented Apr 7, 2023

@napetrov I want to refactor the code, but can you tell me the testing procedure. Particularly I want to refactor those large number of if-elif conditions in /docs/dalapi/doxypy/parser/compound.py

@napetrov
Copy link
Contributor Author

napetrov commented Jun 8, 2023

@shekhar-chauhan @Amruta789 - sorry, missed notifications here. Be free to raise PRs with fixes.

@icfaust icfaust changed the title Code quality improvements - adress findings from www.codefactor.io Code quality improvements - address findings from www.codefactor.io Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants