Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SER-3309): Refactor GA deployment jobs to avoid duplicationg env variables #226

Conversation

amydoxym
Copy link

@amydoxym amydoxym commented Dec 3, 2024

Description

Introduce reusable workflow for deployment to avoid replicate GA env variables

Copy link
Collaborator

@gilclefes gilclefes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link

github-actions bot commented Dec 3, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ YAML yamllint 2 0 0.22s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

sonarcloud bot commented Dec 3, 2024

Copy link
Collaborator

@simiyu17 simiyu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@amydoxym amydoxym merged commit a04db35 into develop Dec 4, 2024
9 checks passed
@amydoxym amydoxym deleted the chore/refactor-deployment-jobs-to-avoid-duplicating-env-variables branch December 4, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants