Updated dependencies; removed pointer analyzer as it panics in go 1.22; updated readme and gitignore
#177
+35
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this be merged? There are many issues regarding pointer analysis. Since golang.org/x/tools/go/pointer has been deprecated, we should either remove it (as it is in this PR), or at least change the default analysis. |
|
Strong +1 for this PR! |
|
+1 for the PR, im also using Go 1.22 and this fixed the error |
minias
added a commit
to minias/go-callvis
that referenced
this pull request
Jun 26, 2024
minias
added a commit
to minias/go-callvis
that referenced
this pull request
Jun 26, 2024
This was referenced Jun 26, 2024
|
Also in my environment, this pr is correctly work, Thanks. git clone https://github.com/ofabry/go-callvis.git
cd go-callvis
gh co 177 # checkout to this nice pull request.
make installgo-callvis .
2024/07/18 15:45:40 http serving at http://localhost:7878
2024/07/18 15:45:40 converting dot to svg..
2024/07/18 15:45:40 serving file: /var/folders/../../go-callvis_export.svg |
|
Is there anyone besides @ondrajz who can merge this PR? |
|
With 1.23.1 , getting this error now on this branch
|
|
Will this be merged? There are many issues regarding pointer analysis. |
wangzhankun
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
The main changes to the code are:
- Removed the code related to "golang.org/x/tools/go/pointer" and its associated code, as it caused numerous issues.
- Added the -algo parameter.
- Upgraded the Go version to 1.22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #170