Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency truncation #71

Closed
rsuzuki0 opened this issue Nov 28, 2021 · 4 comments · Fixed by #75
Closed

Frequency truncation #71

rsuzuki0 opened this issue Nov 28, 2021 · 4 comments · Fixed by #75
Assignees
Labels
enhancement New feature or request

Comments

@rsuzuki0
Copy link

I think the frequency is currently truncated to a whole kHz, but can that be left untruncated?

I often QSY by 500Hz or so to avoid QRM. I usually log that fact on paper and it'd be nicer if that stays in the ADIF.

@jmMeessen
Copy link
Collaborator

The ADIF specification allows it (Frequency is in Mhz and supports decimals) I still need to check for the FLE specification.

I will try to implement something like: normalize to Khz (3 digits after Mhz) unless there are more significant digits (down to the Hz). Need some more thoughts to do properly.

@jmMeessen jmMeessen self-assigned this Nov 29, 2021
@jmMeessen jmMeessen added this to the v0.1.4 add POTA support milestone Nov 29, 2021
@jmMeessen jmMeessen added the enhancement New feature or request label Nov 29, 2021
@rsuzuki0
Copy link
Author

My preference is not to change the number of significant digits by truncation. I would probably only record/specify what I find meaningful myself. But I can't predict others' behavior... Thanks!

@jmMeessen jmMeessen linked a pull request Dec 5, 2021 that will close this issue
@rsuzuki0
Copy link
Author

So you decided to truncate to 100Hz? The document says 500Hz.

@jmMeessen
Copy link
Collaborator

Rounding when using floats (internal storage) and converting to string can be tricky. I chose a quick solution.

The principle is that if the frequency has been entered in the FLE file with more than 3 digits after the "." (checked with a regex), I truncate to the 100 Hz(no rounding), otherwise the frequency is aligned on the Khz. See

khzPart := regexpKhzPartOfQrg.FindStringSubmatch(element)

I don't know what is the behaviour of the original (windows) program. And I can't check as the old family windows machine died last summer.

But we can definitely revisit this behaviour (and open a new issue). Let's see if the first "production run" gives other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants