Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yaml.CSafeLoader whenever possible for speedups #1149

Closed
wouterzwerink opened this issue Jan 16, 2024 · 0 comments · Fixed by #1150
Closed

Use yaml.CSafeLoader whenever possible for speedups #1149

wouterzwerink opened this issue Jan 16, 2024 · 0 comments · Fixed by #1150
Assignees

Comments

@wouterzwerink
Copy link
Contributor

wouterzwerink commented Jan 16, 2024

Is your feature request related to a problem? Please describe.
yaml.CSafeLoader is much faster than the currently used yaml.SafeLoader

Describe the solution you'd like
Try to use yaml.CSafeLoader (not always possible) and fall back to the old loader.

Describe alternatives you've considered
Keeping the slower parser or monkey patching this externally instead of supporting it in OmegaConf itself.
Allowing the user to set a base loader could also work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant