-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: log #5
Comments
Wouldn't that just be part of the data bucket? |
Should the data in the "log" key be shown to the end user on the page or should it just be accessed by the browser console? |
@trondhuso @sathya717 weather or not logs are accessible in the user interface or in the web console would be outside of the scope of a standard like this. It would certainly be accessible from inspecting the network tab in development tools. |
IMHO, this is an application level requirement. One could wonder if the log is about a success or an error. That makes you think if you use log, then should the data at a deeper level mention something about the type of log? That type could be anything like debug, error, success, warning, notice, etc. I think that a regular JSend |
@asiby I disagree, logs are generally not an application concern. If I want to query a service - the data that I'm expecting should not contain a log key with information about how the service produced the response. However, I can see that there are circumstances where you would want to turn on some extra debugging that, and it would be convenient if that debugging can be returned with a response out-of-line of the core payload so it doesn't effect the application. |
Where I come from - the news production world - there are placeholders to tell when an article was first produced and when it was last updated. That is part of the data. Wouldn't you also perhaps require a separate log connection and response if you need such information? And then that debug-information would be part of the data-bucket... Just some thoughts. |
Thankyou for this helpful spec. I would like to request an addition to the spec - an optional key "log" which would be a list of log data generated during any given transaction.
For example:
I don't think it is needed to specify what the type of itmes in the log key are. For example they could be dictionaries.
Motivation: Particularly in admin interfaces it is helpful to have more detail on actions taken. For example an application could detect that a user is a system admin and generate more information in the return objects.
The text was updated successfully, but these errors were encountered: