Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validator contract address check on initialize method #96

Closed
patitonar opened this issue Oct 11, 2018 · 1 comment
Closed

Add validator contract address check on initialize method #96

patitonar opened this issue Oct 11, 2018 · 1 comment
Assignees
@patitonar

Comments

@patitonar
Copy link
Contributor

See this comment #91 (comment)

This affects all bridge modes. On initialize method of bridge contract, we should add a check to verify that validatorContract is a contract address. The same check should be added for token contracts too.
@patitonar patitonar self-assigned this Oct 23, 2018
patitonar added a commit that referenced this issue Oct 24, 2018
@patitonar
Merge branch 'develop' into add-validator-check-on-initialize-#96
eecbf21 
# Conflicts:
#	test/native_to_erc/home_bridge_test.js
@patitonar patitonar mentioned this issue Oct 24, 2018
Merged
@ghost ghost added review and removed in progress labels Oct 24, 2018
patitonar referenced this issue Oct 29, 2018
@patitonar
Merge pull request #102 from poanetwork/add-validator-check-on-initia…
5201d93 
…lize-#96

Add validator and token contract address check
@akolotov
Copy link
Collaborator

akolotov commented Nov 6, 2018

Addressed in #102.

@akolotov akolotov closed this as completed Nov 6, 2018
@ghost ghost removed the review label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patitonar patitonar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patitonar @akolotov