Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default gas price is not initialized for ForeignBridge contract in erc-to-erc mode #86

Closed
akolotov opened this issue Sep 23, 2018 · 1 comment
Closed

Default gas price is not initialized for ForeignBridge contract in erc-to-erc mode #86

akolotov opened this issue Sep 23, 2018 · 1 comment
Assignees
@patitonar
Labels
bug Something isn't working

Comments

@akolotov
Copy link
Collaborator

Due to incorrect copy of ForeingBridge implementation when erc-to-erc bridge mode was introduced, the following line was missed:

https://github.com/poanetwork/poa-bridge-contracts/blob/fef87310b523be908b16295d777fd0215878dad8/contracts/upgradeable_contracts/native_to_erc20/ForeignBridgeNativeToErc.sol#L35

So, it caused uninitialized gasPrice value in the storage after deployment and configuration of ForeignBridge contract:

https://github.com/poanetwork/poa-bridge-contracts/blob/fef87310b523be908b16295d777fd0215878dad8/contracts/upgradeable_contracts/erc20_to_erc20/ForeignBridgeErcToErc.sol#L15-L29
@akolotov akolotov added the bug Something isn't working label Sep 23, 2018
@patitonar patitonar mentioned this issue Sep 24, 2018
Merged
4 tasks
@patitonar patitonar self-assigned this Oct 3, 2018
@patitonar patitonar removed the backlog label Oct 3, 2018
@patitonar patitonar mentioned this issue Oct 3, 2018
Merged
@ghost ghost added the in progress label Oct 3, 2018
@akolotov akolotov mentioned this issue Oct 5, 2018
Merged
akolotov referenced this issue Oct 17, 2018
@akolotov
Merge pull request #91 from poanetwork/gasPrice-foreign-erc-erc-#86
9c20897 
Add gas price on initialization of Foreign erc-to-erc mode
@akolotov
Copy link
Collaborator Author

Addressed by 38565d2.

@ghost ghost removed the review label Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patitonar patitonar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@igorbarinov @pablofullana @patitonar @akolotov