(Feature) Update metamask popup #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add type and reword error messages - handle errors by type
- Create `NoWallet` component - Include it into `App` component
ghost
assigned 
|
Deploy preview for kind-kilby-95344f processing. Built with commit 06d1555 https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c0589649a063f4a9b814ae3 |
akolotov
approved these changes
Dec 1, 2018
patitonar
reviewed
Dec 3, 2018
patitonar
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
Aside from creating the required modal. I also make the error handling more specific for each type of error. There are 3 different errors (no wallet installed, no wallet unlocked, and wallet account rejected -this is metamask specific-)
You can see the behavior for each type of error here (I'll let a transcription of the text displayed in each scenario; for any change required):
no wallet installed
message:
no wallet unlocked
message:
wallet account rejected
message: