Replace deprecated version of staking.CreateValidator

[Zodomo]

Problem to Solve

Staking.sol's createValidator(bytes calldata pubkey) function has been replaced with createValidator(bytes32 x, bytes32 y, bytes calldata signature). The old function is still in place to prevent tests from breaking, but the old function needs to be removed entirely. Every reference to staking.CreateValidator in the Go codebase needs to be corrected. Once this is finished, we can update the Staking contract.

Proposed Solution

Completely remove the deprecated function in Staking.sol, and then update every instance of staking.CreateValidator to use the updated interface. Instead of providing a compressed public key, the X and Y coordinates are necessary, as well as an EIP-712 signature of the coordinate pair. The new getValidatorPubkeyDigest(bytes32 x, bytes32 y) function can be used to retrieve the hash to sign. Running make fix-golden in the root directory of the Omni repo after removing the old Solidity function is one way to see each instance of the broken staking.CreateValidator call.

[Zodomo]

Some files that need updating:

• e2e/app/valupdates.go
• cli/cmd/staking.go

[corverroos]

Add support for new CreateValidator in e2e and cli.

Deprecating old createValiudator can be postponed.