Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Return JSON responses from core #33

Open
omeryusufyagci opened this issue Oct 7, 2024 · 1 comment
Open

Improvement: Return JSON responses from core #33

omeryusufyagci opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
core Media processing component, the core C++ binary. hacktoberfest This issue is eligible for Hacktoberfest contributions improvement Improve existing functionality

Comments

@omeryusufyagci
Copy link
Owner

omeryusufyagci commented Oct 7, 2024

Currently the backend relies on parsing stdout to determine if the MediaProcessor was able process properly the requested media.

Add sendSuccessResponse(), and sendErrorResponse() to Utils, and ensure the status is propagated properly throughout.

Example:

if (!configManager.loadConfig("config.json")) {
    ResponseHandler::sendErrorResponse("Could not load configuration.");
    return 1;
}

This needs the corresponding backend code to be updated to ensure functionality. Will be merged together, from the dedicated branch opened here.

@omeryusufyagci omeryusufyagci added improvement Improve existing functionality backend core Media processing component, the core C++ binary. hacktoberfest This issue is eligible for Hacktoberfest contributions and removed backend labels Oct 7, 2024
@DDibyajyot
Copy link

Hey, I'd love to work on this, could I get assigned this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Media processing component, the core C++ binary. hacktoberfest This issue is eligible for Hacktoberfest contributions improvement Improve existing functionality
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants