-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop setup.py test form to run tests #60
Comments
The upgrade of this testing stack to Rocky Linux 9 in #66 seems to have caused some unwanted regression related to the logging in the standard output. Dropping the usage of On the question above, note also that |
Looking at https://github.com/ome/omero-metadata/pull/85/files, is the/another question whether or not we can start calling pytest by default from the original cli-build without needing to override? |
Discussed earlier today with @joshmoore @jburel @pwalczysko @khaledk2 @dominikl. No objection to looking into the replacement of |
See ome/omero-demo-cleanup@886c01d#r60744714 for the initial discussion
Probably most relevant is the recommendation from Pytest to avoid using
setup.py test
- see https://docs.pytest.org/en/latest/explanation/goodpractices.html#do-not-run-via-setuptools.We still use this semantics in the
omero-test-integration
omero-test-infra/app-build
Line 20 in d03e942
omero-test-infra/scripts-build
Line 11 in d03e942
omero-test-infra/cli-build
Line 17 in d03e942
In addition to complying with the recommendations, dropping the setuptools form has the advantage of removing the need for the custom pytest command class copied and pasted across all plugins - https://github.com/search?q=org%3Aome+%22%28test_command%29%22&type=code.
As a proof of concept, https://github.com/ome/omero-demo-cleanup/blob/44482aa7b7200677ccf16899a0b47cc8c9d8f936/.omeroci/cli-build#L17-L18 uses the direct form
pytest -sv test
after setting ICE_CONFIG.Probably the biggest thing that is being lost is the installation of test dependencies like
mox3
(currently viatest_requires
). I could imagine several solutions ranging fromrequirements-{dev,test}.txt
to specifying some test requirements viaextra_requires
. Do we have a feeling for the most appropriate way to capture this?The text was updated successfully, but these errors were encountered: