Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand PATH to find Python/Pip executables #159

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jul 19, 2017

See Homebrew/homebrew-core#14408

Following a recent change in Homebrew core, the python executable is no longer available under the PATH by default. This PR implements the workaround used in Homebrew/brew#2897 to minimize the number of changes in the code.

An alternative might be to use a virtual environment using the system Python i.e.

sudo easy_install pip
sudo pip install virtualenv
virtualenv /tmp/omero_venv
source /tmp/omero_venv

To be reviewed with @jburel in the context of OMERO 5.4.0

@jburel
Copy link
Member

jburel commented Sep 22, 2017

With the work on the documentation see ome/omero-documentation#1766
I will be in favour of doing in the minimum here and revisit the actual commands in this repo or deprecate that section
We have never used the code snippets in the doc.

@joshmoore
Copy link
Member

@jburel: do you mean you'd take this PR as is or close?

@jburel
Copy link
Member

jburel commented Sep 27, 2017

I will take as it is. We no longer refer to it in our doc following the work by @will-moore and @rgozim
and I will be in favour of deprecating that section

@joshmoore
Copy link
Member

Works for me. Can discuss the future of the /osx/ scripts elsewhere.

@joshmoore joshmoore merged commit 69b301a into ome:develop Sep 27, 2017
@sbesson sbesson added this to the 5.4.0 milestone Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants