Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bake version number into source. #43

Open
mtbc opened this issue Oct 8, 2020 · 0 comments
Open

Bake version number into source. #43

mtbc opened this issue Oct 8, 2020 · 0 comments

Comments

@mtbc
Copy link
Member

mtbc commented Oct 8, 2020

The current version check relies on the Gateway being packaged with its original MANIFEST.MF which, being intended for use as a library, it may no longer be packaged with, depending on what JAR reassembly, package renaming, uberjar approach, etc. is done by downstream build processes. Given the criticality of the version check, a more robust approach may be warranted. For example, one could apply a Gradle equivalent of ome/omero-downloader#44, perhaps reading a filtered properties file from omero-blitz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant