Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameter: fmt -> format #156

Closed
jburel opened this issue Jan 12, 2022 · 2 comments
Closed

Rename parameter: fmt -> format #156

jburel opened this issue Jan 12, 2022 · 2 comments

Comments

@jburel
Copy link
Member

jburel commented Jan 12, 2022

The name of fields in the methods in the library are mostly explicit e.g. columns, wells.
format should be used instead of fmt. See #153 (comment)
@jburel jburel mentioned this issue Jan 12, 2022
Merged
@will-moore
Copy link
Member

I think that format is avoided as a variable name since it would overwrite the built-in format() function:
https://docs.python.org/3/library/functions.html#format

@dstansby
Copy link
Contributor

Probably worth closing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joshmoore @will-moore @jburel @dstansby