feat: use shallow-equal over fbjs #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember a couple of back and forth on this problem two years ago. I think fbjs was used at some point to use the same dependency as React. It's probably no longer used :) |
They dropped it in 16.5: facebook/react@8e87c13 |
|
👌 |
|
Released |
TheAnkurPanchani
pushed a commit
to TheAnkurPanchani/react-swipeable-views
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
fbjs/lib/shallowEqualwithshallow-equal#shallowEqualObjects.fbjsis not intended for usage outside of facebook and pulls in outdated dependencies (e.g.isomorphic-fetch).It doesn't use same-value equality as of yet (proposed in moroshko/shallow-equal#17) but it seems like this isn't an issue here since we control what kind of values we compare.