Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material-ui dialog in slide #13

Closed
zlangbert opened this issue Nov 1, 2015 · 9 comments
Closed

Material-ui dialog in slide #13

zlangbert opened this issue Nov 1, 2015 · 9 comments

Comments

@zlangbert
Copy link
Contributor

If you have a material-ui dialog in a slide after the first, it will pop up in the first slide and you won't see it. Not sure whose issue this would be exactly. I'm sure this problem isn't limited to material-ui dialogs.

@oliviertassinari
Copy link
Owner

That's probably linked to mui/material-ui#1641. This is not specific to this lib. I'm closing the issue.

@oliviertassinari
Copy link
Owner

One way to fix it is to teleport the creation of the dialog dom outside the slider.
But I'm wondering what is exactly responsible for this behaviour

@zlangbert
Copy link
Contributor Author

I think because the dialog is position: fixed it ignores the containers transform3d.

One way to fix it is to teleport the creation of the dialog dom outside the slider.

What do you mean exactly? How would you render the dialog outside its parent?

@oliviertassinari
Copy link
Owner

@oliviertassinari
Copy link
Owner

@zlangbert We are working on this. mui/material-ui#2042 is the first step.

@zlangbert
Copy link
Contributor Author

Great to hear, thanks 👍

@oliviertassinari
Copy link
Owner

@zlangbert Can you try mui/material-ui#2129?

@oliviertassinari
Copy link
Owner

@zlangbert The PR is merged, could you try again?

@zlangbert
Copy link
Contributor Author

@oliviertassinari Sorry I didn't get back to you. I was trying to test it out using material-ui checked out from git but I couldn't get my project to build with it. I just tried 0.1.4.0-rc1 though and it works perfectly. Thanks again for all your help, you guys are awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants