-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material-ui dialog in slide #13
Comments
That's probably linked to mui/material-ui#1641. This is not specific to this lib. I'm closing the issue. |
One way to fix it is to teleport the creation of the dialog dom outside the slider. |
I think because the dialog is
What do you mean exactly? How would you render the dialog outside its parent? |
I'm talking about somethings like https://github.com/rackt/react-modal/blob/master/lib/components/Modal.js#L59. |
@zlangbert We are working on this. mui/material-ui#2042 is the first step. |
Great to hear, thanks 👍 |
@zlangbert Can you try mui/material-ui#2129? |
@zlangbert The PR is merged, could you try again? |
@oliviertassinari Sorry I didn't get back to you. I was trying to test it out using material-ui checked out from git but I couldn't get my project to build with it. I just tried 0.1.4.0-rc1 though and it works perfectly. Thanks again for all your help, you guys are awesome! |
If you have a material-ui dialog in a slide after the first, it will pop up in the first slide and you won't see it. Not sure whose issue this would be exactly. I'm sure this problem isn't limited to material-ui dialogs.
The text was updated successfully, but these errors were encountered: