is tcpProxyProtocol still supported?

[ei8ht187]

Hello again,
sorry to bother you with another question.
in an older release I've seen that you've added tcpProxyProtocol support. Does this function still work? If so, is this synthax in the config.json correct?
"ports": {
"4000": {
"name": "GPU-SMALL",
"listenAddress": "*",
"difficulty": 1,
"tcpProxyProtocol": {
"enable": true,
"mandatory": false,
"proxyAddresses": ["1.2.3.4","2.3.4.5"]
}

As I plan to use a cloud loadbalancer, it would be great to define proxy networks instead of single proxy addresses. Don't know how miningcore handles configfiles with more than 60k lines ;).

Kind regards

ei8ht

[oliverw]

It is supposed to work like that yes.

[ei8ht187]

Okey, tested again today with the offered distributed LB from our hoster:
Using Proxyprotocol v2 show the following debug error:

[2022-01-16 21:13:46.0931] [I] [eth1] [0HMEP6J6Q0VBV] Accepting connection from ::ffff:10.108.33.135:3482 ... 
[2022-01-16 21:13:46.1237] [D] [MessageBus] Listening to Miningcore.Mining.StratumShare: 
[2022-01-16 21:13:46.1241] [I] [eth1] [0HMEP6J6Q0VBV] Connection from ::ffff:10.108.33.135:3482 accepted on port 8888 
[2022-01-16 21:13:46.1241] [D] [eth1] [0HMEP6J6Q0VBV] [NET] Waiting for data ... 
[2022-01-16 21:13:46.1241] [D] [eth1] [0HMEP6J6Q0VBV] [NET] Received data: 


QUIT
!
 Ր���J}�ƒ"�{"id":1,"jsonrpc":"2.0","method":"eth_submitLogin","worker":"eth1.0","params":["0xEb96D606f6b1fe7041b9957939d03aba3EaB79d4", "x"]} 
 
[2022-01-16 21:13:46.1241] [D] [eth1] [0HMEP6J6Q0VBV] [NET] Waiting for data ... 
[2022-01-16 21:13:46.1241] [D] [eth1] [0HMEP6J6Q0VBV] [PIPE] Waiting for data ... 
[2022-01-16 21:13:46.1241] [D] [eth1] [0HMEP6J6Q0VBV] [PIPE] Received data: 


QUIT
!
 Ր���J}�ƒ"�{"id":1,"jsonrpc":"2.0","method":"eth_submitLogin","worker":"eth1.0","params":["0xEb96D606f6b1fe7041b9957939d03aba3EaB79d4", "x"]} 
 
[2022-01-16 21:13:46.1241] [E] [eth1] [0HMEP6J6Q0VBV] Connection json error state: Unable to deserialize request 
[2022-01-16 21:13:46.1241] [I] [eth1] [0HMEP6J6Q0VBV] Connection closed 

While Proxyprotcol V1 gives a Spoofwarning. Any chance to disable this?
Proxyprotocol V1:

[2022-01-16 21:15:11.4099] [I] [eth1] [0HMEP6J6Q0VCE] Accepting connection from ::ffff:10.ZZZ.ZZZ.ZZ7:21000 ... 
[2022-01-16 21:15:11.4099] [D] [MessageBus] Listening to Miningcore.Mining.StratumShare: 
[2022-01-16 21:15:11.4099] [I] [eth1] [0HMEP6J6Q0VCE] Connection from ::ffff:10.ZZZ.ZZZ.ZZ7:21000 accepted on port 8888 
[2022-01-16 21:15:11.4099] [D] [eth1] [0HMEP6J6Q0VCE] [NET] Waiting for data ... 
[2022-01-16 21:15:11.4099] [D] [eth1] [0HMEP6J6Q0VCE] [NET] Received data: PROXY TCP4 2XX.XXX.XXX.XX8 1YY.YYY.YYY.YY3 50838 8888
[2022-01-16 21:15:11.4099] [D] [eth1] [0HMEP6J6Q0VCE] [NET] Waiting for data ... 
[2022-01-16 21:15:11.4099] [D] [eth1] [0HMEP6J6Q0VCE] [PIPE] Waiting for data ... 
[2022-01-16 21:15:11.4099] [D] [eth1] [0HMEP6J6Q0VCE] [PIPE] Received data: PROXY TCP4 2XX.XXX.XXX.XX8 1YY.YYY.YYY.YY3 50838 8888
[2022-01-16 21:15:11.4233] [E] [eth1] [0HMEP6J6Q0VCE] Connection error state: System.IO.InvalidDataException: [0HMEP6J6Q0VCE] **Received spoofed Proxy-Protocol header from ::ffff:10.ZZZ.ZZZ.ZZ7**
   at Miningcore.Stratum.StratumConnection.ProcessProxyHeader(ReadOnlySequence`1 seq, TcpProxyProtocolConfig proxyProtocol)
   at Miningcore.Stratum.StratumConnection.ProcessReceivePipeAsync(CancellationToken ct, TcpProxyProtocolConfig proxyProtocol, Func`4 onRequestAsync) in /home/ubuntu/docker/miningcore/src/Miningcore/Stratum/StratumConnection.cs:line 281 
[2022-01-16 21:15:11.4233] [I] [eth1] [0HMEP6J6Q0VCE] Connection closed

Kind regards

ei8ht

[oliverw]

You didn't mention that you are using v2. MC only supports v1 (text-mode) at the moment.

[ei8ht187]

I tested both :) the second log part is from proxyprotocol v1. There I get some strange spoofing errors (Received spoofed Proxy-Protocol header from ::ffff:10.ZZZ.ZZZ.ZZ7).
The same happens on my now self installed HAPRoxy. But I'm very unfamiliar with haproxy, maybe also a mistake on my side. The pattern itself is the same as with the cloud LB:

[2022-01-16 22:51:02.0226] [I] [eth1] [0HMEP7FVB1BRJ] Accepting connection from ::ffff:[LB internal IP]:45062 ...
[2022-01-16 22:51:02.0226] [D] [MessageBus] Listening to Miningcore.Mining.StratumShare:
[2022-01-16 22:51:02.0226] [I] [eth1] [0HMEP7FVB1BRJ] Connection from ::ffff:[LB internal IP]:45062 accepted on port 8888
[2022-01-16 22:51:02.0226] [D] [eth1] [0HMEP7FVB1BRJ] [NET] Waiting for data ...
[2022-01-16 22:51:02.0226] [D] [eth1] [0HMEP7FVB1BRJ] [NET] Received data: PROXY TCP4 [my public IP] [LB public IP] 59602 8888
{"id": 1, "method": "mining.subscribe", "params": ["lolMiner 1.42", "EthereumStratum/1.0.0"]}

[2022-01-16 22:51:02.0226] [D] [eth1] [0HMEP7FVB1BRJ] [NET] Waiting for data ...
[2022-01-16 22:51:02.0226] [D] [eth1] [0HMEP7FVB1BRJ] [PIPE] Waiting for data ...
[2022-01-16 22:51:02.0226] [D] [eth1] [0HMEP7FVB1BRJ] [PIPE] Received data: PROXY TCP4 [my public IP] [LB public IP] 59602 8888
{"id": 1, "method": "mining.subscribe", "params": ["lolMiner 1.42", "EthereumStratum/1.0.0"]}

[2022-01-16 22:51:02.0226] [E] [eth1] [0HMEP7FVB1BRJ] Connection error state: System.IO.InvalidDataException: [0HMEP7FVB1BRJ] Received spoofed Proxy-Protocol header from ::ffff:[LB internal IP]
at Miningcore.Stratum.StratumConnection.ProcessProxyHeader(ReadOnlySequence1 seq, TcpProxyProtocolConfig proxyProtocol) at Miningcore.Stratum.StratumConnection.ProcessReceivePipeAsync(CancellationToken ct, TcpProxyProtocolConfig proxyProtocol, Func4 onRequestAsync) in /home/ubuntu/docker/miningcore/src/Miningcore/Stratum/StratumConnection.cs:line 281
[2022-01-16 22:51:02.0226] [I] [eth1] [0HMEP7FVB1BRJ] Connection closed

[oliverw]

You have to add the IP Address of your proxy that MC considers to be spoofed to the proxyAddresses array.

[ei8ht187]

I had the the following in my config.json:
"proxyAddresses": ["LB internal IP"]
and got the spoofing. This seems not to be enough as the LB is reportet in IPv6 format for what reason ever. So I played a bit around and set the following:
"proxyAddresses:" : ["::ffff:[LB internal IP]","[LB internal IP]"] in the array.

This solved my problem. Something I should have come up by myself earlier -.-

[n1ckl4s]

Hi there!

The stratum v2 is still disabled or someone managed to work with it?

Could you help me?

Thanks!

Gustavo GP

[oliverw]

Hi there!

The stratum v2 is still disabled or someone managed to work with it?

Could you help me?

Thanks!

Gustavo GP

It was never disabled.

[n1ckl4s]

Hi bro!

I have 1 s9 with the BraiinsOS!

Tried to mine with it and could never connect to the pool, I don't see anything wrong with the settings.