Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ConfirmationDialog: focussed button does not show any focus indicator #1138

Open
Dtrieb opened this issue Jul 8, 2024 · 3 comments
Open
Labels

Comments

@Dtrieb
Copy link

Dtrieb commented Jul 8, 2024

If I selected a system command like shutdown Ueli ask:

Are you sure (yes or not)

In this dialog I can't select the yes or no Buttons with my keyboard.

@Dtrieb Dtrieb added the bug label Jul 8, 2024
@oliverschwendener
Copy link
Owner

Did you try Tab?

@Dtrieb
Copy link
Author

Dtrieb commented Jul 8, 2024

Did you try Tab?

No I try it tomorrow.

But on the old version (8.x.x) yes was selected as default and I could change with the arrow keys.

@oliverschwendener oliverschwendener changed the title [Bug] yes or no buttons didn't choose with keyboard [Bug] ConfirmationDialog: none of the buttons is focused Jul 10, 2024
@oliverschwendener
Copy link
Owner

I just tested it and it works as follows: the "No" button is focused by default, altough there is no focus indicator. This seems to be an issue in the UI library that ueli uses: https://react.fluentui.dev/?path=/docs/components-dialog--default#change-focus. Nevertheless, by pressing Tab you can jump to the "Yes" button and then press enter to confirm the dialog.

@oliverschwendener oliverschwendener changed the title [Bug] ConfirmationDialog: none of the buttons is focused [Bug] ConfirmationDialog: focussed button does not show any focus indicator Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants