Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternatives to dropping Firefox bookmarks support? #1005

Closed
oscardianno opened this issue May 1, 2023 · 1 comment · Fixed by #1085
Closed

Alternatives to dropping Firefox bookmarks support? #1005

oscardianno opened this issue May 1, 2023 · 1 comment · Fixed by #1085

Comments

@oscardianno
Copy link

oscardianno commented May 1, 2023

Hello :)

I was reading through the newest release changelog (8.24.0), where I noticed the breaking change "Removed support for Firefox bookmarks due to sqlite and pnpm implications", and after reading the commits, I was able to see that the problem is caused by a pnpm's issue with the sqlite3 dependencies, which causes the build to fail when running pnpm package to build the installer.
However, npm run package worked just fine, so I wanted to propose:

Is it possible that we use npm instead of pnpm (while the pnpm's team solves the issue) instead of completely dropping the feature?

Perhaps, there's something else that I'm missing?
Otherwise, I'd drop a PR if needed, please let me know ^^


The issue is already documented in the pnpm's repo, and there's a workaround available, though perhaps not so convenient:

open pnpm.cjs file, replace #!/usr/bin/env node with #!node,from electron-userland/electron-builder#6933 (comment)

this can be fixed in my windows by edit 'AppData\Roaming\npm\node_modules\pnpm\bin\pnpm.cjs', but how to let other users auto fix this, all users need change like this?

Originally posted by @AiHaibara in pnpm/pnpm#5638 (comment)

@oliverschwendener
Copy link
Owner

I just added support for Firefox bookmarks back for ueli v9. If you want to try it out you can download the latest alpha version here: https://github.com/oliverschwendener/ueli/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants