Fix regeneratorRuntime errors #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #797
This was referenced Nov 16, 2019
Closed
|
@hipstersmoothie it seems that this PR has fixed the issue as confirmed by myself and @andrewrt |
|
@crutchcorn can you fix up the merge conflicts? |
|
No problem, will do |
# Conflicts: # packages/custom/package.json # packages/jimp/package.json # packages/plugin-blit/package.json # packages/plugin-blur/package.json # packages/plugin-circle/package.json # packages/plugin-color/package.json # packages/plugin-contain/package.json # packages/plugin-cover/package.json # packages/plugin-crop/package.json # packages/plugin-displace/package.json # packages/plugin-dither/package.json # packages/plugin-fisheye/package.json # packages/plugin-flip/package.json # packages/plugin-gaussian/package.json # packages/plugin-invert/package.json # packages/plugin-mask/package.json # packages/plugin-normalize/package.json # packages/plugin-print/package.json # packages/plugin-resize/package.json # packages/plugin-rotate/package.json # packages/plugin-scale/package.json # packages/plugin-shadow/package.json # packages/plugin-threshold/package.json # packages/plugins/package.json # packages/type-gif/package.json # packages/type-jpeg/package.json # packages/type-png/package.json # packages/types/package.json
|
Resolved |
|
🚀 PR was released in v0.9.3 🚀 |
This was referenced Feb 23, 2020
This was referenced Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #797 and #817
What's Changing and Why
This now uses
@babel/plugin-transform-runtimeand@babel/runtimein order to fix issues with the runtime builds in the current version.We also updates core-js to version 3 to keep versions as up-to-date as possible
What else might be affected
This would be a patch release, or a minor release (as it changes deps from
core-jsfrom2to3, which may potentially break transitive deps)Tasks
This has been tested against node-vibrant with an upgraded version of jimp that originally had #797 issues
Published PR with canary version:
0.9.2-canary.815.538.0