Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support sleep for st7920, mini12864 #519

Open
luxflow opened this issue Mar 20, 2022 · 1 comment
Open

Add support sleep for st7920, mini12864 #519

luxflow opened this issue Mar 20, 2022 · 1 comment

Comments

@luxflow
Copy link
Contributor

luxflow commented Mar 20, 2022

I saw powersave feature is implemented for st7920, mini12864 in u8g2
https://github.com/olikraus/u8g2/blob/30e78ca9890ac51df8cff4c99756d231eea21efb/csrc/u8x8_d_uc1701_mini12864.c#L70-L84
https://github.com/olikraus/u8g2/blob/30e78ca9890ac51df8cff4c99756d231eea21efb/csrc/u8x8_d_st7920.c#L62-L79

Is powersave feature in u8g2 different fromt sleep feature in u8glib?
if those are same, could you explain why it is not implemented in u8glib?
maybe?.. Note: There will be no more development for U8glib. Please use [u8g2](https://github.com/olikraus/u8g2/wiki).
Can I PR for this issue?

Thanks!

@olikraus
Copy link
Owner

if those are same, could you explain why it is not implemented in u8glib?

There is no reason. It is just like it is.

Can I PR for this issue?

to u8g2, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants