Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide implementation details from try_scan! #30

Open
kangalio opened this issue Jul 25, 2020 · 1 comment
Open

Hide implementation details from try_scan! #30

kangalio opened this issue Jul 25, 2020 · 1 comment

Comments

@kangalio
Copy link

The following two macro variants seem to be more of an implementation detail than a part of the public API

(@question_mark: $($e:tt)+) => { ... };
(@unwrap: $($e:tt)+) => { ... };

When I first encountered it, I puzzled over them a good while to figure out what library users where supposed to achieve with this. Only after a while did I realize that this was an implementation detail for the bottom-most macro rule.

To avoid this confusion and clear up the docs, these two macro rules could be moved into a separate, private macro

@oli-obk
Copy link
Owner

oli-obk commented Jul 25, 2020

Makes sense. Maybe we can also do something like #[doc(hidden)] or what that flag is? Not sure if that works on macro arms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants