Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Sticky Footer JS Missing #1095

Closed
aibrean opened this issue Sep 29, 2017 · 4 comments
Closed

Sticky Footer JS Missing #1095

aibrean opened this issue Sep 29, 2017 · 4 comments

Comments

@aibrean
Copy link

aibrean commented Sep 29, 2017

I noticed that the data element for the sticky footer is applied, but the JS to make it sticky isn't in the codebase.

@colin-marshall
Copy link
Collaborator

colin-marshall commented Sep 30, 2017

I noticed this too but forgot to open an issue or do a PR. I think it got removed in the update to Foundation 6.4 and it appears the data attribute was forgotten. Thanks for reporting!

@olefredrik was the intention to fully remove the sticky footer functionality in the update?

@olefredrik
Copy link
Owner

Actually I think it was removed by mistake.

@JPOak
Copy link
Contributor

JPOak commented Oct 1, 2017

Just for the record if people have issues and do a search. I did have a conflict with stickyfooter.js and some fullscreen sliders when changing screen sizes and responsiveness. It took me a bit to track down as there were no errors. However, things corrected themeselves after removing stickyfooter.js . I had just started with Foundationpress, so wasn't completely familiar with all its workings. Just a headsup.

@colin-marshall
Copy link
Collaborator

@JPOak it may be due to the problems with Sticky in Foundation which I need to find time to tackle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants