Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually add external link icon to menu items #215

Closed
tom-papatheodore opened this issue Mar 2, 2020 · 4 comments · Fixed by #219
Closed

Manually add external link icon to menu items #215

tom-papatheodore opened this issue Mar 2, 2020 · 4 comments · Fixed by #219
Assignees

Comments

@tom-papatheodore
Copy link
Contributor

On the main training landing page (https://docs.olcf.ornl.gov/training/index.html), the links properly show the "external link" icon. However, the corresponding links in the menu do not. This breaks our standard to always show when users are being directed away from the docs.

NOTE: If you embed e.g., a unicode arrow, the arrow does show up in the menu, however, the links on the landing page include both the correct icon and the arrow - so this is no good.

@jack-morrison jack-morrison self-assigned this Mar 2, 2020
@jack-morrison
Copy link
Contributor

With _static/{css,js}/ we should be able to write some javascript that looks for the presence of http or https in the menu l2 hrefs and give them a custom CSS class include a FontAwesome external icon ::after

(link to icon)

@jack-morrison
Copy link
Contributor

It would be best to do this for all levels of the main nav, not just the training section.

@grahamlopez
Copy link
Contributor

This exact issue is why I avoided putting external links in the navigation for the training to begin with.

@jack-morrison
Copy link
Contributor

I think with a little bit of custom JS/CSS we can handle this one. I'm up to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants